Allow Postgres PVC expansion - #34
Merged
Merged
Conversation
Bumps grpc from v1.78.0 to v1.82.1 to address vulnerabilities in the xDS RBAC authorization engine and HTTP/2 transport server implementation. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Previously, any change to spec.database.size on an existing OpenStackLightspeed instance returned ErrPostgresPVCSizeMismatch, forcing users to delete the PVC (and lose all data) to resize storage. Now the operator distinguishes three cases: - Expand: patches the PVC's storage request to the larger value. - Equal: no-op, no error. - Shrink: returns ErrPostgresPVCSizeShrink with a clear message showing the current and requested sizes; the PVC is not modified. Unit tests cover all three cases using a fake client. Kuttl tests was considered by rejected because it requires the cluster's default StorageClass to have allowVolumeExpansionenabled, which can not be assumed in a portable test environment. And since kuttl also has no proper mechanism to skip tests conditionally it would produce unreliable results across different clusters. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Collaborator
Author
|
/retest |
Collaborator
Author
|
/retest unrelated failure in the -bundle test: There are no nodes that your pod can schedule to |
Collaborator
Author
|
/retest "the build ci-index-openstack-lightspeed-bundle failed after 14s with reason FetchImageContentFailed: Failed to extract image content" |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any change to spec.database.size on an existing OpenStackLightspeed instance returned ErrPostgresPVCSizeMismatch, forcing users to delete the PVC (and lose all data) to resize storage.
Now the operator distinguishes three cases:
Unit tests cover all three cases using a fake client. Kuttl tests was considered by rejected because it requires the cluster's default StorageClass to have allowVolumeExpansionenabled, which can not be assumed in a portable test environment. And since kuttl also has no proper mechanism to skip tests conditionally it would produce unreliable results across different clusters.